Trrack / trrackjs

A library for history/provenance tracking in web-based visualizations.
https://apps.vdl.sci.utah.edu/trrack
BSD 3-Clause "New" or "Revised" License
17 stars 7 forks source link

Untracked slices still appearing in state #34

Open dvzacharycutler opened 1 year ago

dvzacharycutler commented 1 year ago

Example here https://github.com/datavisyn/sightline/blob/mweigl/145_trrack-vis/src/store/store.ts. The untrrackedAppSlice is created with a normal createSlice call, instead of the createTrrackableSlice. It's state still appears on the node, and is still set when traversing back to this node. This creates problems, as our app doesn't expect traversing to affect this part of the store.

dvmartinweigl commented 1 year ago

Just wanted to mention this issue currently makes TrrackVis unusable in our application (sightline). We introcuded a toggle in the unttrackedAppSlice to handle opening/closing a drawer to render TrrackVis. Navigation within the graph is now randomly closing the drawer, because of unintentional toggle state change.

kirangadhave commented 1 year ago

I have isolated where the issue happens. I will try to have the fix in a couple of days. I will get a beta release made for testing in the sightline project.

dvmartinweigl commented 1 year ago

Great to hear. Just let us now as soon the fix is in place and we will test it in sightline.