search

Trrack / trrackvis

BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Updates to ProvVisCreator + dependency typings #37

Closed kirangadhave closed 1 year ago

kirangadhave commented 1 year ago

config parameter in ProvVisCreator is now optional, so no need to pass {} to satisfy Typescript.

ProvVisCreator accepts an additional optional parameter REACT_16 as a boolean. The default value is false. Setting this as true uses the legacy rendering API from ReactDOM, else it uses the new createRoot API.

Updated the dependency typings to support lowest version with hook support all the way till latest major release.

github-actions[bot] commented 1 year ago

👋 @kirangadhave Review your pull request on chromatic: https://www.chromatic.com/pullrequest?appId=63ee57592a53ae7413d27e43&number=37

nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7f6efbae1fa96771c2941de0bffa3a443365e7e5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 8 targets - [`nx build-storybook react --output-dir /tmp/chromatic--1730-e5BJDXLi126J`](https://cloud.nx.app/runs/6UhIglggWI) - [`nx affected --target=test --parallel 5`](https://cloud.nx.app/runs/sArLRQHcT3) - [`nx affected:build --exclude`](https://cloud.nx.app/runs/874oRulofO) - [`nx affected --target=lint`](https://cloud.nx.app/runs/dOAwZk3nBu) - [`nx build-storybook react --output-dir /tmp/chromatic--1806-A3IzD75Q4HUm`](https://cloud.nx.app/runs/ZvWEGy9F1n) - [`nx build-storybook react --output-dir /tmp/chromatic--1870-PJeAGGamLjrM`](https://cloud.nx.app/runs/wRk1FFrNyk) - [`nx build-storybook react --output-dir /tmp/chromatic--1749-2EojKNw7F8Ov`](https://cloud.nx.app/runs/jnqOEXgHkY) - [`nx build-storybook react --output-dir /tmp/chromatic--1848-GBnA4XonwPAm`](https://cloud.nx.app/runs/7h3bRnrW52)

Sent with 💌 from NxCloud.