Token inflation, validator staking/slashing, governance

shanev commented 5 years ago

[x] migration to adjust community tax
[x] add module app account module accounts (user growth pool, stakeholder pool)
[x] app account abci function to distribute to module accounts
[x] add staking module account (user reward pool)
[x] staking abci function to distribute to user reward pool
[x] migration script with initial amounts (see https://github.com/cosmos/cosmos-sdk/blob/a922dad3468b4695e2ad7562d71cfc0ed87da328/x/genaccounts/legacy/v0_36/migrate.go)
[x] allocate to stakeholder pool in account module
[x] add user growth and stakeholder allocation params to account module genesis + migration
[x] add user reward allocation params to staking module genesis + migration
[x] test for account abci / user growth and stakeholder allocation
[x] set current supply + check fund amounts
[x] start begin blocker for distribution module
[x] fix CLI commands
[x] fix testnet
[x] update app.go according to latest gaia
[x] run testnet that properly mints inflation and flows through distribution -> fee_collector -> our pools
[x] try SimApp to simulate over time
[x] try to get working with one node
[x] migration for gov, crisis, and slashing
[x] check if fee_collector account needs to be created (doesn't mint already use it?)
[x] figure out exactly how to split user growth and reward pools and amounts
[x] clone beta and test at UI-level
[x] upgrade to cosmos v0.38
[x] use fund pools instead of registrar/reward broker, and minting out of thin air
[x] test
[x] migration to reset community pool
[x] migration for mint to change total inflation to 70%, and fixed max and min
[x] fork Cosmos SDK and add print logs for inflation details on each block
[x] subtract already given out new user tru from user growth pool
[x] subtract already given out interest from user reward pool
[x] fix issue with supply decreasing

shanev commented 5 years ago

How do we fund module accounts / pools?

[x] figure out the account address of module accounts
[x] create genesis accounts for them with funds

Questions:

how are module accounts decoded?
how does the account decoder know what is a module account and what is a regular account

A: must have module_name and module_permissions in genesis account

shanev commented 5 years ago

  address: cosmos17xpfvakm2amg962yls6f84z3kell8c5lserqta
  name: fee_collector
  permissions: []

  address: cosmos1ed82m7snyk8mux8xxpwygvtyq633a4k43rfp8l
  name: user_reward_tokens_pool
  permissions: []

shanev commented 5 years ago

    GenesisAccount struct {
        Address       sdk.AccAddress `json:"address" yaml:"address"`
        Coins         sdk.Coins      `json:"coins" yaml:"coins"`
        Sequence      uint64         `json:"sequence_number" yaml:"sequence_number"`
        AccountNumber uint64         `json:"account_number" yaml:"account_number"`

        OriginalVesting  sdk.Coins `json:"original_vesting" yaml:"original_vesting"`
        DelegatedFree    sdk.Coins `json:"delegated_free" yaml:"delegated_free"`
        DelegatedVesting sdk.Coins `json:"delegated_vesting" yaml:"delegated_vesting"`
        StartTime        int64     `json:"start_time" yaml:"start_time"`
        EndTime          int64     `json:"end_time" yaml:"end_time"`

        ModuleName        string   `json:"module_name" yaml:"module_name"`
        ModulePermissions []string `json:"module_permissions" yaml:"module_permissions"`
    }

shanev commented 5 years ago

A module account address is the cosmos address generated by sdk.AccAddress(crypto.AddressHash([]byte(MODULE_ACCOUNT_NAME)))

shanev commented 5 years ago

New issue:

E[2019-09-25|18:14:20.594] WARNING: Attempt to allocate proposer rewards to unknown proposer . This should happen only if the proposer unbonded completely within a single block, which generally should not happen except in exceptional circumstances (or fuzz testing). We recommend you investigate immediately. module=x/distribution
validator address cosmosvaloper1em44grl9ylmmnwawwp5fjn079kesatwpl2hn74
panic: UnmarshalBinaryLengthPrefixed cannot decode empty bytes

Seems we need to run an actual tesnet for inflation to work. See how much we can fake out in genesis to make progress. Try with docker localnet.

Update: Works with local docker testnet with 4 validators

shanev commented 5 years ago

migrate genesis with beta clone:

[x] export from fresh chain to make sure it works
[x] validate genesis
[x] export genesis from beta
[x] truchaind init test
[x] copy staking and distribution from init to genesis
[x] run migration 16
[x] validate genesis
[x] unsafe-reset-all
[x] truchaind gentx --name reward_broker
[x] truchaind add-genesis-account reward_broker 1000000000000tru
[x] change supply "outstanding_rewards": null,
[x] truchaind collect-gentx
[x] truchaind start
[x] find out why iterating accounts results in 1000000000000tru supply (A: because when starting from a clean chain, the only account is the reward_broker with 1000000000000tru)

shanev commented 5 years ago

[x] fix genutils migrations

genutils should be:

  "genutil": {
      "gentxs": null
  },

shanev commented 5 years ago

panic: invariant broken: supply: total supply invariant
    sum of accounts coins: 100000000tru
    supply.Total:          253644628704484tru

    CRITICAL please submit the following transaction:
         tx crisis invariant-broken supply total-supply

shanev commented 5 years ago

Fix tests:

[x] adjust for now having default admin accounts
[x] find a way to fake module accounts for testing end blockers

shanev commented 5 years ago

Fix initializing chain from scratch

[x] add default admin accounts
[x] fix tests

shanev commented 5 years ago

Export is broken:

truchaind export > test.json
--- level 0 ---
2:48286["s/1,v208" .. "s/latest,v209"]

WARNING: State is not initialized. Returning genesis file.

Fixed: Bug in Cosmos: https://github.com/cosmos/cosmos-sdk/pull/5103/files#diff-bbb4aa0e4c30192fba47fc18e560af52R95

shanev commented 5 years ago

Error validating genesis: ERROR: error validating genesis file test.json: UnmarshalJSON cannot decode empty bytes

[x] step through each module validation to see what failed

shanev commented 5 years ago

Iterating accounts to calculate supply is broken. Find out why it's blank:

panic: invariant broken: supply: total supply invariant
    sum of accounts coins:
    supply.Total:          253644628704484tru

    CRITICAL please submit the following transaction:
         tx crisis invariant-broken supply total-supply

A: Because Cosmos moved accounts to be under auth. Added migration command to CLI.

shanev commented 5 years ago

How to migrate chain with data:

# run trustory migration
python3 github.com/TruStory/truchain/contrib/migration/16-token-inflation.py --exported-genesis ~/genesis.json > genesis2.json

# run cosmos migration
truchaind migrate v0.38 ~/genesis2.json > ~/genesis3.json

# remove old chain data
rm -rf ~/.truchaind

# init chain
truchaind init test

# copy genesis to home folder
cp genesis3.json ~/.truchaind/config/genesis.json

# add back validator
truchaind gentx --name reward_broker --home-client ~/.octopus
truchaind collect-gentxs

# start
truchaind start

shanev commented 5 years ago

Issue with migrating the latest data:

panic: invariant broken: staking: bonded and not bonded module account coins invariant
    Pool's bonded tokens: 100000000
    sum of bonded tokens: 0
not bonded token invariance:
    Pool's not bonded tokens: 0
    sum of not bonded tokens: 0
module accounts total (bonded + not bonded):
    Module Accounts' tokens: 100000000
    sum tokens:              0

    CRITICAL please submit the following transaction:
         tx crisis invariant-broken staking module-accounts

For some reason, the bonded tokens pool starts with 100000000 tru. Remove it from genesis and re-try.

Update: This fucks up the supply because it adds 100000000 to it. Figure out where this is happening.

Update: This is because there's delegated shares in the staking module.

Solution: Write a migration to change it to 0.

shanev commented 5 years ago

Use fund pools instead of registrar/reward broker and minting out of thin air:

[x] migration to lower coins from registrar (or remove since ante-handler is turned off)
[x] migration to remove coins from reward broker
[x] new validator account with a sane amount of tru (re-using reward broker since its already added to AWS, and 100000000 coins is the min)
[x] see if registration signing account can be validator's account and replace registrar
[x] burn user growth funds after user registration
[x] burn user growth fudns after sending gift
[x] change gift CLI to use user growth account
[x] change trustaking interest to use user rewards account
[x] figure out how to start with initial amounts (A: on chain init, check if module accounts are empty, and fund appropriately)
[x] run for 100, 1000 blocks see if inflation and fund pool balances seem right

shanev commented 5 years ago

Module account for stakes:

[x] fill account in staking init genesis
[x] add to account when creating staking
[x] remove from account when expiring stake

TruStory / truchain

Token inflation, validator staking/slashing, governance #798