search

TruckMovers / cordova-plugin-remote-injection

DEPRECATED: Cordova plugin to allow a remote site to interact with cordova's javascript APIs when loaded within a cordova app.
Apache License 2.0
91 stars 95 forks source link

PageLoadPrompt doesn't appear #11

Open clemorphy opened 8 years ago

clemorphy commented 8 years ago

Hi !

I am currently testing your plugin.

I have set my <content src="" /> to a remote website.

The website is loading well.

I have not tested yet to use the Cordova API from my remote JS files.

What I wanted to test first was the "PageLoadPrompt" which is supposed to appear if the remote site can't load.

As I understand, the prompt feature is enabled by default, no need to change the config.xml.

And the default timeout is set to 10 seconds. Am I right ?

So I put my phone in airplaine mode, launch my app, wait for 10 secs, and .... nothing. Grey screen.

Am I missing something ? Do I need to configure something in the config file ?

bradleyjames commented 8 years ago

Are you on iPhone or Android? It's been a while since I messed with this but but I don't think putting the phone in airplane mode triggers the functionality. Adding a notification to tell the user that the app requires a connection would be a good enhancement.

The current functionality is triggered if a request was successfully made and the server is taking too long to respond. The way I tested it was using a proxy, like Charles, and setting the connection speed to be so slow that it took longer than the 10 second timeout.

clemorphy commented 8 years ago

I am testing on Android, on a physical device (Nexus 5, Android 6). Ok, I understand that it tests the loading time, and that if the loading doesn't start, it won't work. As you say, it would be great to have a functionnality that also prompt the user if there is no internet connection.

bradleyjames commented 8 years ago

Thanks for the request. I added something to our internal issue tracker for prioritization. I'll leave it open as an enhancement request as it would be a good thing to have.

Thanks for trying the plugin!