TruckMovers / cordova-plugin-remote-injection

DEPRECATED: Cordova plugin to allow a remote site to interact with cordova's javascript APIs when loaded within a cordova app.
Apache License 2.0
91 stars 95 forks source link

Make sure that cordova is injected only once on android #33

Closed pgaubatz closed 4 years ago

pgaubatz commented 7 years ago

This fixes #15

tisdall commented 7 years ago

I'm unfamiliar with Android development, but is there any way to detect that the webview is crosswalk before bothering to search for the script in the DOM?

pgaubatz commented 7 years ago

Hi @tisdall not that I'm aware of. But what exactly is your concern?

tisdall commented 7 years ago

Well, the issue is only applicable to Crosswalk, so if there was a quick way to detect Crosswalk before searching through the DOM then it'd probably be faster. This is really an issue in Crosswalk so it'd probably be better to encapsulate it in a "if crosswalk then" type statement.