search

TrueBitFoundation / truebit-os

[DEPRECATED] Interactive client
Apache License 2.0
82 stars 26 forks source link

deploy.sh fails with older truffle version #19

Closed hobofan closed 6 years ago

hobofan commented 6 years ago 
Error parsing /Users/hobofan/stuff/truebit/truebit-os/basic-client/incentive-layer/contracts/DepositsManager.sol: ParsedContract.sol:16:16: ParserError: Expected identifier, got 'LParen'
    constructor() public {
               ^
Compilation failed. See above.

I got this error when following the instructions from the README and running deploy.sh. I noticed that the global install of truffle is used to run the migrations. Upgrading to a newer truffle version works, but depending on having the correct truffle version installed globally seems like it would something to break very easily in the future.

@hswick Shouldn't incentive-layer and dispute-resolution-layer bring their own truffle versions with them and then use those to run the migrations? I saw that you recently removed the truffle dependency from incentive-layer. Is there any specific reason for that?

hswick commented 6 years ago

@hobofan I agree that it might be better to provide the truffle versions by the dependencies. I removed it because it was an outdated version I believe.

More than happy to accept PRs to fix this.

hobofan commented 6 years ago

More than happy to accept PRs to fix this.

Will do! :)

hswick commented 6 years ago

I've included the updates. Feel free to reopen if you have any issues.