TrueBitFoundation / truebit-os

[DEPRECATED] Interactive client
Apache License 2.0
82 stars 26 forks source link

[WIP] Mono repo #33

Closed hswick closed 6 years ago

hswick commented 6 years ago

This PR puts all TrueBit smart contracts in one repo. I have also removed a bunch of code that is not being used now. This includes basic-client, wasm-client/webasm-solidity, wasm-client/incentive-layer, as well as basic-client related tests.

Scripts

This PR includes a handful of new scripts to be used during development and prod setup. There is now a custom compilation and deployment script being used to work with the smart contracts. Along with a script to distribute TRU tokens to accounts.

Usage

There have been changes to the npm package commands. You will need to follow the commands in this order to setup the development environment.

npm run fixperms
npm run install
npm run compile
npm run deploy
npm run distribute
npm run test

Todo list

test

implementation

OR13 commented 6 years ago

This is looking great! I think its going to be much simpler to manage in this format moving forward.

Since its WIP, I won't get too critical just yet.

I recommend we stabilize the existing implementation and ci tests before tackling the todos.

I see .gitmodules needs to be cleaned up still.

Its looking like the only submodule will be ocaml-offchain, which I think is a huge improvement!

With all the contracts in this repo now, I feel the test directory should have a structure similar to the contracts directory under the wasm-client, we'll want to make sure incentive and dispute contracts have tests and that we are running them as part of CI.