search

TrueBitFoundation / truebit-os

[DEPRECATED] Interactive client
Apache License 2.0
82 stars 26 forks source link

Finish verification implementation for basic client #4

Closed hswick closed 6 years ago

hswick commented 6 years ago

What is left: Timeouts Use updated dispute resolution layer

OR13 commented 6 years ago

I took a stab at this, but got lost on the differences between TaskExchange & IncentiveLayer.

In particular, after a bit of patching, the verifier choked here:

https://github.com/TrueBitFoundation/truebit-os/blob/master/basic-client/verifier.js#L63

Testing in the incentive layer with truffle test leads me to believe that it is to blame.

given the submodule dependencies, i believe that the submodule tests should be executed before any truebit-os tests, that way its clear if they might be the cause of subsequent failures.

probably not helpful, but my incomplete / broken work can be found here: https://github.com/OR13/truebit-os/commits/feat/challenged-task-flow

hswick commented 6 years ago

TaskExchange is a type of IncentiveLayer, understandable that its a bit confusing. The idea is that it might be the base contract that IncentiveLayer or possible other incentive layers could inherit, but we'll see how that goes.

Running the submodule dependency tests seems like a good idea to me.

One thing I noticed is that the current submodule version is not up to date. I'm not sure if that would fix the problem though.

hswick commented 6 years ago

This has been fixed now.