search

TrueBitFoundation / truebit-os

[DEPRECATED] Interactive client
Apache License 2.0
82 stars 26 forks source link

Off by one error #7

Closed hswick closed 6 years ago

hswick commented 6 years ago

@juztamau5 pointed out in #6 that the final solution is not correct.

The output it is giving is 36 when it should be 45, so that means it isn't adding the last number which is 9.

It is worth checking if it is an error in https://github.com/TrueBitFoundation/dispute-resolution-layer

Oh and the os.js test should check for the correct output as well.

hswick commented 6 years ago

Now that https://github.com/TrueBitFoundation/dispute-resolution-layer/commit/ba231997bec99ea6e95331543b4c56fb979c2d43 has been merged. Next step is to update this code to use the new dispute-resolution-layer