TrueBitFoundation / webasm-solidity

[DEPRECATED] On-chain interpreter for WebAssembly written in Solidity
MIT License
66 stars 12 forks source link

initialize shouldn't return false #97

Open hswick opened 6 years ago

hswick commented 6 years ago

https://github.com/TrueBitFoundation/webasm-solidity/blob/master/contracts/interactive.sol#L124 https://github.com/TrueBitFoundation/webasm-solidity/blob/master/contracts/interactive.sol#L127

Should just revert when not successful because it makes it seem like the tx went through

Should be deleted because if you don't have the proper data then there is a more underlying fault that probably wont be able to mended.

mrsmkl commented 6 years ago

Ok, these are just for debugging, removing them shouldn't do any harm.