search

TrueBlocks / trueblocks-core

The main repository for the TrueBlocks system
https://trueblocks.io
GNU General Public License v3.0
1.05k stars 198 forks source link

Remove go.work (and go.work.sum) files from repo. #3600

Closed tjayrush closed 5 months ago

tjayrush commented 5 months ago

When I create a brand new GitHub repo and select the GoLang .gitignore, the default exclusions include go.work.

According to ChatGPT, this is standard industry practice.

We should add this file (if present) to our .gitignore and remove it from our own local repos and the remote repo.

dszlachta commented 5 months ago

It seems to be more complicated: https://github.com/golang/go/issues/53502 However the Go team seems to lean to "don't check it in" option. We only have go.work because of VS Code complaining. It might be worth checking if we still need it. If we do, one suggestion in the linked issue was to have a script that creates this file.

tjayrush commented 5 months ago

We do need it. VS Code reports errors if it's removed. Those errors go away if the go.work is replaced. I like the idea of a script, especially as I add more and more examples, but when would it run?

tjayrush commented 5 months ago

Done.