search

TrueBlocks / trueblocks-core

The main repository for the TrueBlocks system
https://trueblocks.io
GNU General Public License v3.0
1.05k stars 198 forks source link

chifra transactions -- incorrect output for --ether option #3642

Closed tjayrush closed 4 months ago

tjayrush commented 5 months ago

In the current code, when we do chifra transactions 1001001.0 --ether we get an incorrect result. (Same for other command that export transactions including blocks and export).

We always get both the value and the ether field in all exports of a transaction (even if --ether is not provided), but when it is provided we get an incorrect result.

Without the --ether flag, we get Ether in the ether field and Wei in the value field.

With the --ether flag, we get Ether in both fields.

This is incorrect and will be fixed in version 3.0.0.

tjayrush commented 5 months ago

This is a slightly breaking change in that people who were relying on the value field to be in Ether when the --ether flag is provided will break, but it's justified since they should have been using the ether field instead.