TrueBlocks / trueblocks-core

The main repository for the TrueBlocks system
https://trueblocks.io
GNU General Public License v3.0
1.05k stars 198 forks source link

Remove base.Blknum, base.Txnum, base.Timestamp #3647

Closed tjayrush closed 5 months ago

tjayrush commented 5 months ago

Do this in favor of regular types - eases Unmarshaling of JSON generated by core.

It won't change the docs (which rely on our named types in fields.csv. Just the internal types we use. Note that this will not change any caches.

Not also that this will be a massive change but all smoke no fire.

The reason is so the SDK testing can use JSON output by our own code as input to the sdk test cases plus it greatly clarifies and simplifies the code.

tjayrush commented 5 months ago

Nope.