search

TrueBlocks / trueblocks-core

The main repository for the TrueBlocks system
https://trueblocks.io
GNU General Public License v3.0
1.04k stars 194 forks source link

chifra names - remove unused gRPC server code #3764

Closed tjayrush closed 3 weeks ago

tjayrush commented 3 weeks ago

We never actually used the gRPC code in chifra names. I'm inclined to remove it especially now that we have the SDK.

The reason for the gRPC server was to avoid loading the names database each time the command line tool was called. That won't be solved by removing the feature, but to be honest we've basically never used it, so there's no loss there.

With the SDK which is serving a mini-Dapp, there's no need to "load the names database in a server." The application itself is, in a certain sense, a server in that it can load the names database when it starts and make it available until it does. Just like the server but without the "serilization / stringification" that we so despise.

Alsos, it removes a lot of fairly complicated code.

tjayrush commented 3 weeks ago

@dszlachta Just an FYI in case you ever wonder what happened to the gRPC code.