search

TrueBlocks / trueblocks-docker

GNU General Public License v3.0
39 stars 16 forks source link

Why do we have both --file and $ARGS #335

Closed tjayrush closed 2 years ago

tjayrush commented 2 years ago

On this line:

https://github.com/TrueBlocks/trueblocks-docker/blob/develop/build/core/core.entrypoint.sh#L28

We use both --file and $ARG. Why both? --file is a way to put multiple command lines in a file (like sed -f) all to be run one after the other. I'm not sure we would ever want that for the scraper. Maybe this is a holdover from the chifra monitors command where --file use to be required?

If possible, remove all mentions of --file for the core docker. I don't think we need it.

dszlachta commented 2 years ago

So, we don't use both at the same time (unless configured to do it). The default for both is an empty string. So the file is empty by default. We list both arguments in the command to allow the user to configure both options.