Closed CyMule closed 1 year ago
These are great. Can you please go ahead and make PRs (maybe one per suggestion above to make it easier for me to merge).
@dszlachta If you have any thoughts on these suggestions, please chime in. If not, no problem.
Looks great, thanks @CyMule. One thing that I'd add is to replace /Volumes/IndexCache/trueblocks/*
paths with something more descriptive, like /path/to/your/index
. These are example values so people will want to change them.
Regarding .env
- good catch. I think we can just copy section on it from develop
I walked through the building of the container, and I had a few suggestions for changes that could make on-boarding easier for new users.
Potential Changes / Additions
Volume Flag
In order to use the,
--mount
flag, users need to run the following commands first.sudo mkdir -p /Volumes/IndexCache/trueblocks/unchained
sudo mkdir -p /Volumes/IndexCache/trueblocks/cache
This could be added to the directions before the build, or the-v
volume flag could be used to automatically create the directory. This would make the run command look like this:Documentation on differences between flags:
.ENV
Another step could be added to suggest copying
env.example
. Right now if you clone, build, and try to run you will get an error saying:Adding a step suggesting
cp env.example .env
might reduce friction.FAQ?
I'm not sure exactly where this could be added. Maybe a FAQ? A quick note suggesting the use of
docker rm trueblocks-core
to remove the container after stopping it if you need to restart it. Without removing the container you get a message like:This is obvious if you have used docker enough, but could be useful to add if there are other FAQs.