search

TrueCar / react-launch-darkly

Simple component helpers to support LaunchDarkly in your React app.
MIT License
76 stars 20 forks source link

Update ldclient-js #113

Closed Dnguye92 closed 4 years ago

Dnguye92 commented 4 years ago

This PR is to solve #111. ldclient-js version 2.9.7 was released to reduce the the frequency of how often this error is being thrown.

truecar-cla-bot commented 4 years ago

Hey @Dnguye92, it looks like you haven\'t signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project\'s outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen license. Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you\'ve signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

truecar-cla-bot commented 4 years ago

Hey @Dnguye92, it looks like you haven\'t signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project\'s outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen license. Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you\'ve signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

truecar-cla-bot commented 4 years ago

Hey @Dnguye92, it looks like you haven\'t signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project\'s outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen license. Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you\'ve signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

Dnguye92 commented 4 years ago

[clabot:check]

truecar-cla-bot commented 4 years ago

@TrueCar It looks like @Dnguye92 just signed our Contributor License Agreement. :+1:

Always at your service,

clabot

sethbattin commented 4 years ago

awesome, thanks @Dnguye92! Apologies for the CLA bit; the lawyers demand it.

Are you able to test whether this is effective for your usage using your branch, or would you need some kind of test version published to npm?

Dnguye92 commented 4 years ago

awesome, thanks @Dnguye92! Apologies for the CLA bit; the lawyers demand it.

Are you able to test whether this is effective for your usage using your branch, or would you need some kind of test version published to npm?

@sethbattin I guess a test version?

Dnguye92 commented 4 years ago

@sethbattin how do i go about getting this test version?

sethbattin commented 4 years ago

Apologies, i got distracted after merging and tagging that 4.1.0 version (because i did it wrongly for an npm publish). But you can download it over here and switch to a local file install https://github.com/TrueCar/react-launch-darkly/releases/tag/v4.1.0

But like I said over on #111 , it's unlikely this will fix your issue because ldclient-js is actually a peer dependency. So not only won't this update change anything, but you could have upgraded it in your own npm project at any time without submitting anything this this library. 😐

Apologies again for the runaround; I misread the dev dependencies when i saw your original ticket.