ldClient as peer dep - Githubissues

TrueCar / react-launch-darkly

Simple component helpers to support LaunchDarkly in your React app.

MIT License

76 stars 20 forks source link

ldClient as peer dep #84

Closed hartzis closed 5 years ago

hartzis commented 6 years ago

move ldClient too peerDependencies
- "ldclient-js": "^1.1.12 || ^2.0.0"
- NOTE they are deprecating default import which will probably go away in next major
```
console.warn node_modules/ldclient-js/dist/ldclient.cjs.js:1
[LaunchDarkly] "default export" is deprecated, please use "named LDClient export"
```
fix tests to use devDependencies for "ldclient-js": "^2.7.1"
- need to use require("ldclient-js").default now since they are using named exports now

Will close #81 .

truecar-cla-bot commented 6 years ago

Hey @hartzis, it looks like you haven\'t signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project\'s outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen license. Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you\'ve signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

hartzis commented 6 years ago

[clabot:check]

truecar-cla-bot commented 6 years ago

@TrueCar It looks like @hartzis just signed our Contributor License Agreement. :+1:

Always at your service,

clabot

jacobmoretti commented 5 years ago

@hartzis Sorry this has sat for so long. Do you mind making an update to the "Dependencies" section in the README: https://github.com/TrueCar/react-launch-darkly/blob/master/README.md#dependencies. Just including a quick blurb about the dependency on LaunchDarkly's js client. Specifically outlining that it needs to be installed in the user's app and the versions that are supported.

hartzis commented 5 years ago

Hey, no worries, I can totally do that!

will be a few days after I get back from holiday.

On Thu, Nov 29, 2018 at 13:04 Jacob Moretti notifications@github.com wrote:

@hartzis https://github.com/hartzis Sorry this has sat for so long. Do you mind making an update to the "Dependencies" section in the README: https://github.com/TrueCar/react-launch-darkly/blob/master/README.md#dependencies. Just including a quick blurb about the dependency on LaunchDarkly's js client. Specifically outlining that it needs to be installed in the user's app and the versions that are supported.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/TrueCar/react-launch-darkly/pull/84#issuecomment-442933896, or mute the thread https://github.com/notifications/unsubscribe-auth/AFISkx_YNx6QJSdrgOfleGuZdmNPvNHOks5u0CG9gaJpZM4XasQs .

-- Brian Hartz www.hartzis.me http://www.hartzis.me/about brianhartz@gmail.com