search

TrueCar / react-launch-darkly

Simple component helpers to support LaunchDarkly in your React app.
MIT License
76 stars 20 forks source link

Default export is deprecated - causes warning #89

Closed Kamahl19 closed 5 years ago

Kamahl19 commented 5 years ago

[LaunchDarkly] "default export" is deprecated, please use "named LDClient export"

jamesmosier commented 5 years ago

The fix for this is to change this line to import * as launchDarklyBrowser from "ldclient-js";. Once that is done the tests will need fixed (I believe the mocks get messed up is the reason why).

Also just for reference, the LaunchDarkly team said in future ldclient-js versions that they'll be removing the default export. I'm sure it'll be a little while and would certainly be a major version bump.

janhartmann commented 5 years ago

Any updates on this?

jamesmosier commented 5 years ago

@janhartmann I haven't had time to work on it, so it is up for grabs as far as I know!

jacobmoretti commented 5 years ago

Fixed as part of https://github.com/TrueCar/react-launch-darkly/pull/91. Release patch version coming up!

jacobmoretti commented 5 years ago

Released as part of 3.1.1: https://github.com/TrueCar/react-launch-darkly/releases/tag/v3.1.1