TrueHorse / Wild-Tool-Access

A Minecraft mod, that adds an item quick select.
MIT License
7 stars 2 forks source link

Some settings not working as intended #21

Closed Felisinnn closed 11 months ago

Felisinnn commented 1 year ago

At least two of the options are not working: leadingEmptyslot set to false still displays the first slot as empty, and heldItemSelected set to true does not work for me either.
I've tried changing the setting through ModMenu as well as through the config file but nothings seems to change.

I'm not sure what information would be relevant for this: Version: Wild Tool Access 1.20 - 1.4.0 Loader: Fabric Loader 0.14.24 Minecraft 1.20.1

Mod list:

Captura de pantalla 2023-11-12 221845 Captura de pantalla 2023-11-12 221803

TrueHorse commented 1 year ago

Thank you for the detailed report. I will look into it. :)

Felisinnn commented 1 year ago

Update: my game crashed while trying to switch weapons using the mod. It usually works fine other than the settings from before. Here's the crash log:

Description: Unexpected error

java.lang.NullPointerException: Cannot invoke "net.trueHorse.wildToolAccess.AccessBar.selectItem()" because "this.openAccessbar" is null at net.minecraft.class_329.closeOpenAccessbar(class_329.java:13010) at net.trueHorse.wildToolAccess.WildToolAccessClient.onAccessBindingHeldStatusChanged(WildToolAccessClient.java:76) at net.trueHorse.wildToolAccess.WildToolAccessClient.lambda$onInitializeClient$0(WildToolAccessClient.java:51) at net.fabricmc.fabric.api.client.event.lifecycle.v1.ClientTickEvents.lambda$static$2(ClientTickEvents.java:43) at net.minecraft.class_310.handler$dlk000$fabric-lifecycle-events-v1$onEndTick(class_310.java:13522) at net.minecraft.class_310.method_1574(class_310.java:1957) at net.minecraft.class_310.method_1523(class_310.java:1181) at net.minecraft.class_310.method_1514(class_310.java:802) at net.minecraft.client.main.Main.main(Main.java:250) at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470) at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:88) at org.prismlauncher.EntryPoint.listen(EntryPoint.java:126) at org.prismlauncher.EntryPoint.main(EntryPoint.java:71)

A detailed walkthrough of the error, its code path and all known details is as follows:

-- Head -- Thread: Render thread Stacktrace: at net.minecraft.class_329.closeOpenAccessbar(class_329.java:13010) at net.trueHorse.wildToolAccess.WildToolAccessClient.onAccessBindingHeldStatusChanged(WildToolAccessClient.java:76) at net.trueHorse.wildToolAccess.WildToolAccessClient.lambda$onInitializeClient$0(WildToolAccessClient.java:51) at net.fabricmc.fabric.api.client.event.lifecycle.v1.ClientTickEvents.lambda$static$2(ClientTickEvents.java:43) at net.minecraft.class_310.handler$dlk000$fabric-lifecycle-events-v1$onEndTick(class_310.java:13522)

-- Affected level -- Details: All players: 1 total; [class_746['Shawphax'/2, l='ClientLevel', x=-1911.10, y=55.00, z=-1303.34]] Chunk stats: 4096, 1497 Level dimension: minecraft:overworld Level spawn location: World: (0,69,0), Section: (at 0,5,0 in 0,4,0; chunk contains blocks 0,-64,0 to 15,319,15), Region: (0,0; contains chunks 0,0 to 31,31, blocks 0,-64,0 to 511,319,511) Level time: 9403497 game time, 13965309 day time Server brand: fabric Server type: Integrated singleplayer server Stacktrace: at net.minecraft.class_638.method_8538(class_638.java:458) at net.minecraft.class_310.method_1587(class_310.java:2406) at net.minecraft.class_310.method_1514(class_310.java:826) at net.minecraft.client.main.Main.main(Main.java:250) at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470) at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:88) at org.prismlauncher.EntryPoint.listen(EntryPoint.java:126) at org.prismlauncher.EntryPoint.main(EntryPoint.java:71)

-- Last reload -- Details: Reload number: 1 Reload reason: initial Finished: Yes Packs: vanilla, fabric, minecraft:supporteatinganimation, presencefootsteps:default_sound_pack, continuity:default, continuity:glass_pane_culling_fix, file/Fancy+Boss+Bars+v0.1.1.zip, file/Totem Slot Retexture.zip, file/Faithful 32x - 1.20.1.zip, file/cem-opticompat-pack-v1.zip, file/xali's Enchanted Books v0.11.zip, file/Chat+V.1.1.zip, file/Dark-UI-32x-(1.20.1).zip, file/FaithfulApplepeel.zip

TrueHorse commented 1 year ago

Aaaawwsome. 🙂 Thank you again for making the effort to report all of this. From the error it looks like its caused by my "sticky key" implementation for toggleMode. I will look into that as well. For the other two I already identified what causes them not to work, but I don't know yet when I will work on fixing them and reward you for your efforts with a new version.

TrueHorse commented 11 months ago

Ok, I fixed heldItemSelected and lastSwappedOutFirst not working with the stuff type, leadingEmptySlot and a crash with toggleMode disabled that could be the one you had. I still need to port it to the other MC versions before I want to officially release the update, but if you already want the 1.20.2 file, here you go: https://drive.google.com/file/d/18kaa7cByyGACfQaniznT5OVKtvXcU4Tj/view?usp=sharing

TrueHorse commented 11 months ago

Released the files for all supported versions on CurseForge and Modrinth.