search

TrueLayer / ginepro

A client-side gRPC channel implementation for tonic
Apache License 2.0
127 stars 24 forks source link

require lookup_service Future to be Send #29

Closed onatm closed 2 years ago

onatm commented 2 years ago

This will allow the Future stored in lookup_service to be safely moved between threads.

marekgalovic commented 2 years ago

Hey @onatm! Would you mind sharing more details about why this was closed?

onatm commented 2 years ago

Hey @marekgalovic, one of our internal crates was expecting lookup_service to be Send. I prematurely assumed that ginepro would be to the best place to enforce Send rather than relaxing this trait bound in the consuming crate. After a discussion, we decided not to introduce this breaking change and solve this in the consuming crate.