TrueLayer / ginepro

A client-side gRPC channel implementation for tonic
Apache License 2.0
127 stars 24 forks source link

Problems updating from 0.5.1 to 0.5.2 #43

Closed njhill closed 6 months ago

njhill commented 1 year ago

I ran into various problems with this upgrade. Still trying to understand them and have had to revert for now, I'll provide more detail when I can get it.

But think upgrading the tonic dependency from 0.8 to 0.9 should probably have been done in a 0.6.0 version update rather than a patch release.

eopb commented 6 months ago

I'm going to close this issue as stale.

I think you're right that the tonic update should not have happened in a patch release. I did not see this issue at the time. If I had I would have yanked the release. It's now too late to do anything here, sorry about any inconvenience caused.