search

TrueLayer / reqwest-middleware

Wrapper around reqwest to allow for client middleware chains.
Apache License 2.0
257 stars 78 forks source link

Re-introduce default json + multipart features to reqwest #144

Closed tl-eirik-albrigtsen closed 6 months ago

tl-eirik-albrigtsen commented 6 months ago

to allow .json() etc on RequestBuilders

think this should probably not be removed in https://github.com/TrueLayer/reqwest-middleware/commit/60212ae4510a7cabaa7fceb6ca60cc48a7829296# and breaks a couple of things downstream

tl-eirik-albrigtsen commented 6 months ago

missed https://github.com/TrueLayer/reqwest-middleware/blob/main/reqwest-middleware/Cargo.toml#L13-L15 never mind!

LukeMathWalker commented 6 months ago

Should they be re-enabled by default, though?

tl-eirik-albrigtsen commented 6 months ago

it is at the very least an undocumented breaking change from the changelog's POV.. so either that or retro-actively add it to the changelog

i don't mind that it's off by default personally, but can go either way. wdyt @eopb ?

tl-eirik-albrigtsen commented 6 months ago

we went for keeping it off, now added to changelog* retroactively