Closed musicinmybrain closed 5 months ago
I think this is a good change, but I think we can avoid creating the symlinks using cargo package properties: https://doc.rust-lang.org/cargo/reference/workspaces.html#the-package-table
I think this is a good change, but I think we can avoid creating the symlinks using cargo package properties: https://doc.rust-lang.org/cargo/reference/workspaces.html#the-package-table
Do you know a way to configure multiple license files? The linked documentation and https://github.com/rust-lang/cargo/issues/5933 seem to say that this is not currently supported.
Oh, apologies, I was under the impression we had a license file specified, and wanted to make that work in multiple workspace crates, but we actually have a license
field specifying license = "MIT OR Apache-2.0"
. In this case I guess my idea will not work 🙃
Your solution is good. Thank you!
CI test unrelated, merging this.
Great! Thanks for reviewing this PR.
This PR adds symbolic links to the top-level
LICENSE-MIT
/LICENSE-APACHE
files in all three crates (reqwest-middleware
,reqwest-retry
, andreqwest-tracing
), which ensures that these license files appear in the published crates as required by the chosen license terms.Before this PR, using
reqwest-retry
as an example:(no license file appears in the output)
After this PR:
Note that the symbolic links are resolved by
cargo publish
, and regular files appear in the crates.A follow-up commit in this PR adds a changelog entry.