TrueLayer / reqwest-middleware

Wrapper around reqwest to allow for client middleware chains.
Apache License 2.0
257 stars 78 forks source link

Reduce dependencies in reqwest-retry #173

Closed zaczkows closed 1 month ago

zaczkows commented 2 months ago

This pull request is trying to reduce dependencies by:

I hope I did cfg correctly as I'm doing it first time

zaczkows commented 2 months ago

I did something wrong, because it works without any features, but macro should fail...

zaczkows commented 2 months ago

hmmm... looks complex :disappointed:

LukeMathWalker commented 2 months ago

making tracing dependency optional and using log instead

Those crates are not the same, and the choice of tracing here is very intentional.

zaczkows commented 2 months ago

I think I understand the idea, but would then at least be ok to make tracing optional? I can imagine many applications that doesn't need or even want to have tracing.

LukeMathWalker commented 2 months ago

I can imagine many applications that doesn't need or even want to have tracing.

This is the first time someone has expressed this need since this library was created, so there are probably not that many. Having tracing as optional could be accepted, but it'd have to be properly tested in CI.

zaczkows commented 2 months ago

Reduced scope as requested

zaczkows commented 1 month ago

Sorry for a delay, but all the changes should be there