TrueLayer / truelayer-signing

Convenient libraries to produce TrueLayer API requests signatures.
https://docs.truelayer.com/docs/verify-webhook-signatures
Apache License 2.0
19 stars 20 forks source link

Elixir library #267

Open timwis opened 2 months ago

timwis commented 2 months ago

Hi team, I wrote an elixir module a few months ago to handle signing and verifying TrueLayer requests, and thought I'd extract it out into a module. Just wanted to share it here in case other elixir users stumble upon this repo in the future:

https://github.com/timwis/ex_truelayer_signing

Happy to submit it as a PR here if you like - I don't need to be the package owner or anything. I don't quite have your test coverage, though it shouldn't be too hard to add it. But no worries if you don't want to take on the maintenance of another language.

kplattret commented 1 month ago

Hi @timwis, thanks a lot for sharing this! I actually considered writting an Elixir library for this some time back, so if people need one, then it makes sense for us to support it. I'd be happy to help you move it here if that's what you'd like.

I would need to extend the test coverage and we would indeed need to move ownership to TrueLayer for security reasons, but of course we would keep you as an author of the package.

If the above sounds good to you, then perhaps when ready we could release it under a new name (e.g. truelayer_signing) and let the old one be, or deprecate it. What do you think?

timwis commented 1 month ago

Thanks @kplattret that all sounds great. And regarding the name, that makes sense. I deliberately named it with the ex_ prefix so there wouldn't be a conflict, and I'd be happy to deprecate it when replaced.