TrueMyst / BeatPrints

☕ BeatPrints, a tool that generates eye-catching pinterest-style music posters in python
Other
33 stars 5 forks source link

Pypi Release #11

Closed cherriae closed 1 month ago

cherriae commented 1 month ago

The current pyproject.toml doesn't have your email you have to add it manually.

authors = [
    { name="TrueMyst", email="urEmailHere" }
]

There were 2 license: ... License liscense

cherriae commented 1 month ago

I saw #8 so I decided to do it for you cuz you haven't yet

cherriae commented 1 month ago

I've converted src directory name to beatprints and added __init__.py and __main__.py

TrueMyst commented 1 month ago

Amazing work Jerry! Really appreciate the work, I'm fixing a couple of bugs from my side, will push it within a day or two! :)

cherriae commented 1 month ago

There gonna be a big issue with lyrics soon @TrueMyst there seems to be a rate limit

Screenshot_20240503-100254_Instagram.jpg

cherriae commented 1 month ago

I'm also doing some research on getting non python files downloaded too but the problem how do u access the fonts

TrueMyst commented 1 month ago

There gonna be a big issue with lyrics soon @TrueMyst there seems to be a rate limit

Don't you worry, I've moved on from MusixMatch because I've found a better alternative to this. You'll see it very soon!

TrueMyst commented 1 month ago

I'm also doing some research on getting non python files downloaded too but the problem how do u access the fonts

How do I access the fonts? Can you elaborate it more please?

cherriae commented 1 month ago

I'm also doing some research on getting non python files downloaded too but the problem how do u access the fonts

How do I access the fonts? Can you elaborate it more please?

I was thinking about how the fonts will be accessed through packages. This is because when ur installing the package how does the package access the fonts

https://github.com/TrueMyst/BeatPrints/blob/afa63d46054e9e3a9fb5592cff5aba87fc832a4a/src/utils.py#L107-L114 image

cherriae commented 1 month ago

Also instead of pyproject.toml I could do setuptools if u want or find more better

TrueMyst commented 1 month ago

I was thinking about how the fonts will be accessed through packages. This is because when ur installing the package how does the package access the fonts

https://setuptools.pypa.io/en/latest/userguide/datafiles.html

TrueMyst commented 1 month ago

Also instead of pyproject.toml I could do setuptools if u want or find more better

Yeah, setuptools will do me better!

TrueMyst commented 1 month ago

@cherriae I've updated the code a bit, you might want to check it out.

TrueMyst commented 1 month ago

I was thinking about how the fonts will be accessed through packages. This is because when ur installing the package how does the package access the fonts

I'm concerned about the current setup in utils.py where I manually set the fonts. Whenever there's an issue with fonts, I have to manually add them and then repackage the module for PyPi. While I considered letting users add their own fonts, I worry they might change the appearance too much.

Instead, I'm thinking of providing default fonts from my code. For instance, if a user needs a font for Hindi but it's not available, they can specify the file path to add it themselves

I've to modify and optimize writing.py a bit.

cherriae commented 1 month ago

I was thinking about how the fonts will be accessed through packages. This is because when ur installing the package how does the package access the fonts

I'm concerned about the current setup in utils.py where I manually set the fonts. Whenever there's an issue with fonts, I have to manually add them and then repackage the module for PyPi. While I considered letting users add their own fonts, I worry they might change the appearance too much.

Instead, I'm thinking of providing default fonts from my code. For instance, if a user needs a font for Hindi but it's not available, they can specify the file path to add it themselves

I've to modify and optimize writing.py a bit.

Yeah its probably better to let them customize on their own.

cherriae commented 1 month ago

Opening a new pr soon

TrueMyst commented 1 month ago

Opening a new pr soon

Alright mate : ) lemme know if you need any help