search

TrueMyst / BeatPrints

☕ BeatPrints, a tool that generates eye-catching pinterest-style music posters in python
Other
33 stars 5 forks source link

writing: support for hindi #13

Closed T-Dynamos closed 3 weeks ago

TrueMyst commented 3 weeks ago

You're forgetting something. For english-based text, I'm using Oswald for that. I don't prefer using Noto-Sans. Could you review your code again and make a new change to it?

T-Dynamos commented 3 weeks ago 
[['NAACHO NAACHO (FROM "RRR")', './assets/fonts/Oswald/Oswald-Bold.ttf']]
[['Vishal Mishra', './assets/fonts/Oswald/Oswald-Regular.ttf']]
[['03:34', './assets/fonts/Oswald/Oswald-Regular.ttf']]
[['नाचो, नाचो-नाचो, नाचो-नाचो, नाचो, वीरे, नाचो', './assets/fonts/NotoSans/NotoSans-Light.ttf']]
[['नाचो, नाचो-नाचो, नाचो-नाचो, नाचो, यारा, नाचो', './assets/fonts/NotoSans/NotoSans-Light.ttf']]
[['नाचो, नाचो-नाचो, आ दोबारा राग छेड़ा, नाचो', './assets/fonts/NotoSans/NotoSans-Light.ttf']]
[['नाचो, नाचो-नाचो, उसने चखा लागे तीखा, नाचो', './assets/fonts/NotoSans/NotoSans-Light.ttf']]
[['October 22, 2022', './assets/fonts/Oswald/Oswald-Regular.tt
f']]
[['T-Series', './assets/fonts/Oswald/Oswald-Regular.ttf']]

It is using Oswald indeed.

TrueMyst commented 3 weeks ago

Oh, my bad so you're using Noto Sans for Hindi? Ah- I was using Noto Sans Devanagari for Hindi text.

Could you show me a poster about a hindi song? Maybe you can try "Husn" or something.

T-Dynamos commented 3 weeks ago

husn_by_anuv_jain_8378

TrueMyst commented 3 weeks ago

Looks good to me, but there seems to be an issue with the spacing. image

This was not supposed to be like that.

It was supposed to be like this. image

There should be a space in between, do you think you've change the co-ordinates or something?

T-Dynamos commented 3 weeks ago

No, you need to increase spacing a little bit, this behavior is default. We have to subtract y value from bounding box of font from original y. (to support multilangs)

TrueMyst commented 3 weeks ago

image

On line 84, it should be chunks.append(...), if you can fix that.

And to avoid huge files, could you please keep these font variants in the Noto-Sans folder, since we are not using all of them? image

That's all.

T-Dynamos commented 3 weeks ago

On line 84, it should be chunks.append(...), if you can fix that.

Nice catch!

TrueMyst commented 3 weeks ago

LGTM! Let's push it :>

TrueMyst commented 3 weeks ago

Everything looks good so far, but the texts got a bit too much of y-offset. Lemme see if I can fix it.