TrueOsiris / docker-vrising

Container for V-Rising dedicated server
244 stars 63 forks source link

Fix gracefully shutdown and add container wide log files #55

Closed Diyagi closed 6 months ago

Diyagi commented 6 months ago

Refactor was needed in order to capture the entire container log (including things like steamcmd) reliably.

The gracefully shutdown i had written previously wasnt actually waiting for the gameserver to shutdown, i tried with kill -SIGINT on multiple processes, tried using wineserver -k but none of those actually were properly shutting it down, so i came up with the solution of shutting it down on an more windows way.

TrueOsiris commented 6 months ago

Way to many unnecessary changes imho.

Diyagi commented 6 months ago

Way to many unnecessary changes imho.

Splitting it into init.sh and start.sh also makes easier to change this into an non-root approach too, that was the second reason.