TrueOsiris / docker-vrising

Container for V-Rising dedicated server
237 stars 63 forks source link

Improvements to start.sh #70

Closed lytedev closed 4 months ago

lytedev commented 4 months ago

Most of the improvements are from shellcheck but I also had issues with the kill in the sigterm handler not working, presumably due to trying to kill after the server crashes in my case. By changing this to better handle the situation where the pid cannot be found, we avoid waiting forever and the container can die and be restarted by docker/podman/whatever properly.

Hope this is helpful to others!