Can accidentially overwrite .smd files

TruePikachu / pmDJ

Pokémon Mystery DJ - SMD/SWD conversion tools for PMD2

0 stars 2 forks source link

Can accidentially overwrite .smd files #8

Open TruePikachu opened 10 years ago

TruePikachu commented 10 years ago

A mistyped invocation for pmDJ can result in accidentially overwriting a .smd file with .mid data

pmDJ foo.smd bar.smd - Overwrites bar.smd with MIDI data from foo.smd
pmDJ foo.smd bar.smd baz.mid - (intended command) Writes MIDI data to baz.mid

Solution would be to check the file extension on the argv[argc-1] argument.

TruePikachu commented 10 years ago

Quick note I'm not putting in the issue report proper, eventually, we might have pmDJ foo.mid bar.smd, so it might be beneficial to check all the file extensions and validate them.