search

TrueWinter / DiscordBot

My Discord bot. Development has been stopped
https://blog.truewinter.dev/2020/04/09/development-and-support-for-my-discord-bot-has-been-stopped
Apache License 2.0
46 stars 42 forks source link

Error #22

Closed ghost closed 6 years ago

ghost commented 6 years ago

Uncaught Exception: TypeError: guildSettings.swearWords.someword is not a function how this possible ?

TrueWinter commented 6 years ago

Just tested the swear word blocking part of the bot and it seems to be working fine for me. If possible, can you give me some more information such as:

TrueWinter commented 6 years ago

@donkeymonkey1 As there has not been any reply in 10 days from my last reply, and there does not seem to be any problem found with the code while testing, this issue will be closed. If a reply is received, the issue will be reopened.

TrueWinter commented 6 years ago

After more testing, without knowing exactly what the issue is from your side, I think I may have found the problem. My testing showed that having a value other than an array for the swearWords configuration option will cause the error that you received. Data type checking for configuration options may be added into a future version of the bot but it is currently a low priority.

I did not add this type of check into the bot because at the time, I thought it was not necessary. I overlooked an important part of error checking here. As said earlier in this reply, it will be added into a future version but is not high priority.

For this reason, the issue will be reopened and will be listed as a P2 priority (where P0 is the highest and P3 is the lowest).

The testing can be found online at https://l.ndt3.ml/2EYdqFj. The testing was done on an online service called repl.it.

Thank you for the report.

ghost commented 6 years ago

It's problem with dashboard ...

ghost commented 6 years ago

When someone change anything in dashboard Uncaught Exception: TypeError: guildSettings.swearWords.someword is not a function and bot crash

TrueWinter commented 6 years ago

Yeah, it is a problem with the dashboard trying to convert a string to an array but failing to do so. The swearWords configuration option then gets sent to the configuration options for that guild as a string and as .some expects to be used on an array, it gives an error and crashes.

The code that was added to try to overcome this problem a few months ago was quickly written and not properly tested. I only tested it in a way that I knew it would work and didn't test it with values that could fail to work.

Changing this to a P1 priority bug.

TrueWinter commented 6 years ago

@donkeymonkey1 Thank you once again for reporting this bug. The issue with updating settings from the dashboard (and the set command) of the bot should now be fixed.

ghost commented 6 years ago

:+1: