search

TrueWriter / get-flash-videos

Automatically exported from code.google.com/p/get-flash-videos
0 stars 0 forks source link

mpeg layer 3 (mp3) magic numbers excluded #376

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
The file 
http://fotf.cdnetworks.net/fotf/mp3/fof_daily_broadcast/ffd_2012/2_april_may_jun
e/ffd_20120409.mp3 , downloadable using URI 
http://www.focusonthefamily.com/popups/media_player.aspx?MediaId={66F03180-B560-
4A5B-B013-CDDEAEC5418B} and patch from #365, doesn't include ID3 information. 
It has the following three bytes of hex:

  ff fb 70

This contradicts http://www.digitalpreservation.gov/formats/fdd/fdd000105.shtml 
which says the magic is "ff fb 30". Someone else, 
http://filext.com/file-extension/mp3 , says that the magic number is just "ff". 
I propose that since we at least know that "ff fb" is common between an actual 
MP3 and the first cited description of the MP3 format that we add a check for 
"ff fb".

Without supporting this, the user is given the message "Sorry, file does not 
look like a media file, aborting." when trying to download the referenced mp3.

Original issue reported on code.google.com by ohnobinki on 10 Apr 2012 at 1:03

GoogleCodeExporter commented 8 years ago

Original comment by ohnobinki on 10 Apr 2012 at 1:05

Attachments:

GoogleCodeExporter commented 8 years ago 
Applied and committed, thanks for the patch.

Original comment by zakflash...@gmail.com on 11 Apr 2012 at 7:18