Truly-Modular / Modular-Item-API

A Modern Modular Item API
Other
26 stars 8 forks source link

Greatsword charged attack does not inherit the sharpness enchantment. #51

Closed CSNinja1 closed 3 months ago

CSNinja1 commented 3 months ago

When a modular greatsword is enchanted with sharpness, its charged attack does not inherit the damage given by that specific enchantment, meaning sharpness does not increase the damage of the greatsword's charged attack.

A video demonstrating what I am talking about: https://github.com/user-attachments/assets/57497c7e-b949-4f1b-9d0c-f8953dd7feb9

Smartin-b commented 3 months ago

Huh. yeah, your right, enchantments arent currently allowed to modify output damage directly, this will be fixed in the next release

Smartin-b commented 3 months ago

https://modrinth.com/mod/modular-item-api/versions release is out