Trung0246 / ComfyUI-0246

Random nodes for ComfyUI
MIT License
108 stars 11 forks source link

[FEATURE SUGGESTION] - Bidirectional Highway syntax #10

Closed alessandroperilli closed 10 months ago

alessandroperilli commented 10 months ago

I finally started testing the Highway and Junction node in a serious way. (I also plan to test the other batch of new ones, which look seriously powerful).

Hence, I remembered one of the reasons why I had to postpone the adoption of either in the AP Workflow: #2. Without the capability to reverse direction of in and out pins, my workflow would become an unsustainable mess.

That said, while testing the Highway node, I found myself in the situation of attempting to replicate a stack of reroute nodes:

Screenshot 2023-11-26 at 21 18 02

Writing down every label in both directions is a minor annoyance, but it gave me the idea for a tweak of the syntax (if possible).

Right now we write a query like >pinA, <pinA. Could we write a query like <>pinA to shortcut the creation of two in and out pins with identical labels*?

Just a thought.

UPDATE You have implemented the layout direction! I just didn't notice until now. But, just like for rgthree, when the layout is reversed, the pin labels disappear. Is that a technical limitation of ComfyUI? If so, this whole Issue is mostly pointless.

Trung0246 commented 10 months ago

Hm not sure since I used rgthree function to actually do the heavy works of flipping layout. Since I don't have control over that you could try to ask over rgthree repo.

Trung0246 commented 10 months ago

Probably gonna close this too since the issue over rgthree got closed and it looks like inherent limitation unfortunately.

https://github.com/rgthree/rgthree-comfy/issues/58