Trung0246 / ComfyUI-0246

Random nodes for ComfyUI
MIT License
108 stars 11 forks source link

[BUG?] STRING widgets stick on screen #21

Closed mortael closed 8 months ago

mortael commented 8 months ago

Hey,

I have the following when I have ComfyUI-0246 installed. STRING widgets that should be out of screen, stay sometimes sticked on the canvas. Screenshot: image

It's most noticeable with 'Follow Execution' on (from Comfyui-custom-scripts), but without it also happens. I tried a new clean install of ComfyUI, with only ComfyUI-0246 installed, and using the 'Default' nodes to generate the purple glass image. I copied those nodes 2 or 3 times, each placed out of screen. I then run the prompt, and go from the running node to one of the others out of screen. And then the STRING widget from the Clip Text Node sticks on screen. It goes away when I go back to it.

It happens random, so not each time every STRING widget, sometimes only the Positive one, the other time both. The same happens a lot with Note nodes.

What could this be?

Trung0246 commented 8 months ago

Hm weird. I tried to literally copy-pasting z-index management verbatim from the comfyui dom widget implementation. It looks like I missed something. Checking now.

Surprisingly this does not get reported earlier.

Luckily this is just a visual bug so there's that.

Trung0246 commented 8 months ago

Pushed temp fix that should hopefully works for now. Will keep this issue open.

mortael commented 8 months ago

Thanks, with the temp fix I don't have those sticky widgets anymore 👍