search

Trung0246 / ComfyUI-0246

Random nodes for ComfyUI
MIT License
108 stars 11 forks source link

Multiline widget textboxes stick on screen #22

Closed rgthree closed 8 months ago

rgthree commented 8 months ago

(Originally filed here, but looks like it's this custom node: https://github.com/comfyanonymous/ComfyUI/issues/2568 )

Steps:

  1. Install ComfyUI-0246.
  2. Open default workflow.
  3. Go ahead and a note too, though the clip text encode text boxes will show it too.
  4. Add a node offscreen, and note its node id.
  5. Move the canvas back to your main workflow, with the text areas.
  6. call app.canvas.centerOnNode(app.graph.getNodeById(12)) where 12 is the node id of the node offscreen.
  7. Note that the canvas has moved to be centered on that node, but the three textboxes remain floating on top.

Screenshot 2024-01-16 170110

Trung0246 commented 8 months ago

Trying emergency fix this right now. Will have to deep dive on how comfyui managing the element display and zooming being work. I copy-pasted verbatim the addDOMWidget and this somehow break things. Weird.

Reference: https://github.com/Trung0246/ComfyUI-0246/issues/21

Close as dupe.

Trung0246 commented 8 months ago

Also @rgthree , do you have any ideas on relevant issues in the past that relates to addDOMWidget? The current goal is I'm trying to implement an alternative dynamic widget size mechanism like in ComfyUI but with more options. My implement current works so far right now but it kinda falls off with some backward compatibility stuff like this.

Maybe I should have done more testing.