Trung0246 / ComfyUI-0246

Random nodes for ComfyUI
MIT License
113 stars 11 forks source link

[FEATURE REQUEST] Support for Reroute (native and 3rd parties) nodes in Junction #3

Closed alessandroperilli closed 1 year ago

alessandroperilli commented 1 year ago

The Junction node would be extremely useful if I could connect Reroute nodes to it. Especially rghtree Reroute nodes.

For example, in the following screenshots, I would like to replicate that stack of reversed rgthree Reroute nodes with a single Junction node, but I cannot:

Screenshot 2023-11-07 at 13 18 08

This really is the main use case that triggered my wish list for this node.

Trung0246 commented 1 year ago

Hm since reroute nodes are virtual nodes it may behave differently. Not sure how to deal with this but I'll looks into it.

Btw did you connect the reroute node to the static pin like _junc_in or the dynamic pins? It maybe due to type check problem since reroute node did not have type.

alessandroperilli commented 1 year ago

I connected the reroute node to a dynamic pin, because I want to recreate exactly the stack you see in the screenshot (they are all reroute nodes), but with Junction.

I understand a possible objection: "Why don't you simply place Junction right before the source node you want to transport?" The answer to a similar objection is that very often the source nodes are spread apart or in awkward positions and a reroute node is often necessary.

Trung0246 commented 1 year ago

I guess you means "dynamic pins" not "dynamic nodes" but yeah that the underlying problem of reroute node have unknown type.

Trung0246 commented 1 year ago

I have change some code. Can you test it to see if Reroute (including rgthree) works again? Will probably close this issue since looks like on my side it probably been fixed. Maybe need more test idk. Will probably open later.

alessandroperilli commented 1 year ago

It does work fine:

Screenshot 2023-11-08 at 10 13 01

Thank you.