TrungKien2705 / df-frontend-2023

https://trungkien-assignment-3.vercel.app/
1 stars 0 forks source link

Submission for assignment - 1 #2

Open TrungKien2705 opened 1 year ago

TrungKien2705 commented 1 year ago

Assignment - 1

zlatanpham commented 1 year ago

Hello @TrungKien2705, great start!

Requirements

Final result: ✅ passed

Feedback

We also have some comments for your work:

  1. Try to avoid using inline JS in your HTML. Use .addEventListener() in script.js file to maintain separation of concern. https://github.com/TrungKien2705/df-frontend-2023/blob/master/assignment-1/index.html#L86
  2. Consider adding aria-label="close" for better accessibility https://github.com/TrungKien2705/df-frontend-2023/blob/master/assignment-1/index.html#L157
  3. It's a good practice to associate the label with the input by for and id attribute image
  4. Always sanitize and validate data from the user to prevent potential security vulnerabilities like XSS attacks https://github.com/TrungKien2705/df-frontend-2023/blob/master/assignment-1/script.js#L115-L123 image