Trust-Machines / BNS-V2

MIT License
10 stars 3 forks source link

The `stx-burned` field refers to `uSTX` #71

Open BowTiedRadone opened 1 month ago

BowTiedRadone commented 1 month ago

Summary

I found that in the name-preorders and namespace-preorders maps, there is a field called stx-burned. However, the values inserted into these maps are actually in uSTX (microstacks). This might be confusing for users interacting with the smart contract.

Example

The maps declaration:

Inserting entries into the maps:

Suggestion

I suggest renaming stx-burned to ustx-burned or adding comments to indicate that the amount represents uSTX.

Thank you! CC: @moodmosaic @wileyj

Patotking12 commented 1 week ago

Ok, yes this can be done and implemented