Trust-Machines / BNS-V2

MIT License
18 stars 6 forks source link

Fix Registration Functions #8

Closed setzeus closed 6 months ago

setzeus commented 6 months ago

Description

While reviewing the previous parts of this issue (manager registration) I ran into an issue in the exist registration functions 'name-claim-fast' & 'name-preorder.' The first (stx-burn? ...) function for the namespace manager is not correct / not needed.

The point of exposing a namespace manager interface is to allow for customizations such as:

Currently, both of these functions explicitly burn-stx. This is not correct. The manager path for both of these functions should be free since it's assumed that the manager namespace is calling into this with the customized logic in their contract.

User Stories

Action Items

Open Questions

Patotking12 commented 6 months ago

Updated the name-claim-fast function, We only keep this one and we only burn if it is being called from a non managed namespace