TrustPoint-Project / trustpoint

MIT License
5 stars 0 forks source link

[BUG] Fix cosmetic issues #60

Open Aircoookie opened 3 months ago

Aircoookie commented 3 months ago

Some UI is not consistent. Fix before initial release.

AlexHx8472 commented 3 months ago

Regarding the tables in general. My suggestion would be to get rid of django-tables2 and do it manually with the build in features of django including pagination in the long term (using a ListView). As far as I understand tables2 is not that active in regards to development and we would get rid of another dependency, especially in the context of the future CRA issue. If you guys agree, we could use this to rework the styles of the card and the whole table appropriately.

Aircoookie commented 3 months ago

I agree we don't necessarily require django-tables2 to generate our tables. The only major feature we would need to replace with a custom implementation is sort-by-column, which boils down to using order_by on the queryset.

AlexHx8472 commented 3 months ago

Yes, and since we will need to manipulate the queryset anyway for searching the table contents, this shouldn't be much of an issue. Most work will likely be adding styled links to the column headers, that should basically be it.