update election review view

[trustthevote]

in the view of an election in the review step, and in the similar view on the dashboard, change list of checkbox text to display the following. Change "Configuration" to "Settings" have one checkbox for "All configurations complete" ~and another for "All URLs provided"~

Under Election Data, change "Ballot Definitions Provided" to "Election Definition Uploaded". Delete the 3rd bullet. (If there is mismatch, that would be a failed ballots upload and the second box would not be checked)

Under Voter Data, have two checkboxes: "Test Voter File Uploaded" and "Production Voter File Uploaded"

[cwisdo]

@trustthevote How should we define the state "All configurations complete?"

[trustthevote]

"All configurations complete" = everything on the configs/settings page complete: every boolean having an explicit yes or no, every pull down with a selection, every blank filled in with valid stuff (DL min and max being numeric only, multiple use notice DL example being plain text)

[trustthevote]

really shouldn't let the user leave the page without providing a decision on everything (which can be changed later).

Same for the first page with election name/etc.

[cwisdo]

@amekelburg @trustthevote

Currently the admin conflates forward/back navigation with the "save" function.

I think we should have an explicit save/update button on these screens instead (where we can do the validation mentioned above... all items required). Similarly a "Create Election" button on the create screen vs. simply moving forward.

This will have the added benefit of allowing us to re-use these screens for reviewing archived election settings (where we would not include the save/update button).