Fairadapt inclusion in AIF360

Trusted-AI / AIF360

A comprehensive set of fairness metrics for datasets and machine learning models, explanations for these metrics, and algorithms to mitigate bias in datasets and models.

https://aif360.res.ibm.com/

Apache License 2.0

2.46k stars 840 forks source link

Fairadapt inclusion in AIF360 #257

Closed dplecko closed 2 years ago

dplecko commented 3 years ago

Hi guys,

Here is a pull request adding three files we mentioned (fairadapt.py, test_fairadapt.py and demo_fairadapt.ipynb).

Most importantly: the installation of the necessary R-packages using rpy2 is currently done from the fairadapt class (check fairadapt.py line 54). I am guessing you would be looking for a better solution, i.e., that R-packages are installed together with AIF. Please just make sure, if this option is used, that we have installed:

ranger version 0.13.1
fairadapt version 0.2.0

Both of the above are now available via CRAN, which should make installing them using conda much easier!

Thank you in advance for attending to this!

Best, Drago

lgtm-com[bot] commented 3 years ago

This pull request introduces 13 alerts when merging 3ff929e3075c66dc2d4cfea036487b8f73ac0388 into fcda24e8760cfb66ba5a1b24c2cec33e8101a730 - view on LGTM.com

new alerts:

12 for Unused import
1 for Module is imported more than once

nrkarthikeyan commented 3 years ago

Hi @dplecko - can you check the LGTM report above and remove unused imports?

lgtm-com[bot] commented 3 years ago

This pull request introduces 13 alerts when merging 6236e0feebb1206f92dd05253cc56135481fa17e into a5dac73786265415138ed6e2f8c926d9ee968ee5 - view on LGTM.com

new alerts:

12 for Unused import
1 for Module is imported more than once

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging 580a5a72dc8a9d1cee14ec18013f8a3b4d6321bf into a5dac73786265415138ed6e2f8c926d9ee968ee5 - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging 59257dd7612dbb1bd1033356a5ae175ee1f01ede into a5dac73786265415138ed6e2f8c926d9ee968ee5 - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging f3bf4171ceff073bb6762ff788b40811833f0e9a into a5dac73786265415138ed6e2f8c926d9ee968ee5 - view on LGTM.com

new alerts:

1 for Unused import

nrkarthikeyan commented 2 years ago

CI workflows failing at the R interface

@dplecko's analysis:

Fixed several warnings, but the major thing to be solved is the following: when trying to install fairadapt R-package using rpy2, I come across a problem because the default paths on the machine where the continuous integration is running are not writable WARNING rpy2.rinterface_lib.callbacks:callbacks.py:123 R[write to console]: 'lib = "/usr/local/lib/R/site-library"' is not writable for this reason, the installation tries to run interactively and ultimately fails. When running locally, I doubt that this would be a problem. I was wondering if adding fairadapt to ci.yml would solve the problem? In particular, adding it here: L81: run: install.packages(c("reticulate", "rstudioapi", "testthat")) I am wondering if that would help? Not sure if the .libPaths() are shared between rpy2 and default R distribution on the machine. Alternatively, the package installation could be moved somewhere else. Do you perhaps know how to specify a dependency to an rpy2-R-package directly in setup.py ?

@SSaishruthi @gdequeiroz @hoffmansc - Any thoughts on how to fix this?

hoffmansc commented 2 years ago

Maybe I'm missing something but do we not need to install R first in the build-py section of ci.yml? i.e.,

- name: Set up R
  uses: r-lib/actions/setup-r@v1