search

Trusted-AI / AIF360

A comprehensive set of fairness metrics for datasets and machine learning models, explanations for these metrics, and algorithms to mitigate bias in datasets and models.
https://aif360.res.ibm.com/
Apache License 2.0
2.46k stars 840 forks source link

Update component.yaml to kfp v2 sdk #259

Closed yhwang closed 3 years ago

yhwang commented 3 years ago

Update component.yaml to kfp v2 compatible. In v2, you need to declare the data type for all of the input/output arguments.

Signed-off-by: Yihong Wang yh.wang@ibm.com

yhwang commented 3 years ago

/cc @Tomcli

Tomcli commented 3 years ago

So KFP is working on a new v2 design that requires few extra fields from its components. Part of the requirements is to specify the input/output parameter type for all the KFP components for the new design. This PR is to address this change.

nrkarthikeyan commented 3 years ago

@Tomcli , @yhwang - does this change preserve backward compatibility?

Tomcli commented 3 years ago

@Tomcli , @yhwang - does this change preserve backward compatibility?

No, the type field was optional in the old KFP version. However, the upcoming v2 KFP version will make the type required sometimes next year, so we want to update the AIF360 component to be ready for the new KFP versions.

nrkarthikeyan commented 3 years ago

From your response, it seems like type field is optional now, but will become mandatory later. So including the type field would preserve backward compatibility right? Just making sure it wont break any existing code.

Tomcli commented 3 years ago

From your response, it seems like type field is optional now, but will become mandatory later. So including the type field would preserve backward compatibility right? Just making sure it wont break any existing code.

yes it will preserve backward compatibility. Nothing will break from this PR. Sorry I probably didn't interpret your message correctly in my last comment.

nrkarthikeyan commented 3 years ago

Ok approved and merged.

Tomcli commented 3 years ago

thanks @nrkarthikeyan