search

Trusted-AI / AIF360

A comprehensive set of fairness metrics for datasets and machine learning models, explanations for these metrics, and algorithms to mitigate bias in datasets and models.
https://aif360.res.ibm.com/
Apache License 2.0
2.46k stars 840 forks source link

Update CONTRIBUTING.rst #464

Open mrxy56 opened 1 year ago

mrxy56 commented 1 year ago

Changed the order of authors.

mrxy56 commented 1 year ago

https://github.com/Trusted-AI/AIF360/issues/237 Above is the issue.

hangrychae commented 1 year ago

Same issue with MAINTAINERS.md #463.

hoffmansc commented 1 year ago

I'm confused. Weren't they already in order by last name (except for Gabriela)?

mnagired commented 1 year ago

ah, looks like the change was to be in order by first name, whichever is preferred @hoffmansc

hoffmansc commented 1 year ago

By last name is better IMO. Can we actually keep track of it in only MAINTAINERS.md instead of both files and just link to that file here?

Btw, the current list of maintainers with write privileges are:

mnagired commented 1 year ago

@mrxy56 @hangrychae could you please coordinate and make the necessary changes to the PR as requested by Sam above? Thanks!

mrxy56 commented 1 year ago

By last name is better IMO. Can we actually keep track of it in only MAINTAINERS.md instead of both files and just link to that file here?

Btw, the current list of maintainers with write privileges are:

  • animeshsingh
  • anupamamurthi
  • gdequeiroz
  • hoffmansc
  • michaelhind
  • mnagired
  • nrkarthikeyan
  • sne3091
  • srnghn
  • SSaishruthi

Firstly, I would suggest using 'letter by letter' alphabetizing since it is recommended here. https://editarians.com/ways-of-alphabetizing/ Secondly, most people are not familiar with ranking by surname which is why there is an issue raised. Third, the name list in MAINTAINERS.md and CONTRIBUTING.rst are not the same.

In MAINTAINERS.md: Animesh Singh (animeshsingh) Gabriela de Queiroz (gdequeiroz) Karthi Natesan Ramamurthy (nrkarthikeyan) Kush Varshney (krvarshney) Michael Hind (michaelhind) Prasanna Sattigeri (pronics2004) Saishruthi Swaminathan (SSaishruthi) Sam Hoffman (hoffmansc) Stacey Ronaghan (srnghn)

In CONTRIBUTING.rst: Animesh Singh (animeshsingh) Anupama Murthi (anupamamurthi) Gabriela de Queiroz (gdequeiroz) Karthikeyan Natesan Ramamurthy (nrkarthikeyan) Manish Nagireddy (mnagired) Michael Hind (michaelhind) Saishruthi Swaminathan (SSaishruthi) Samuel Hoffman (hoffmansc) Stacey Ronaghan (srnghn)

Therefore, they should not be linked. @mnagired @hoffmansc @gowriaddepalli @hangrychae

hoffmansc commented 1 year ago

Hi @mrxy56, thanks for following up.

Coming from an academic background, it is customary to list authors by surname -- first name is never done (see https://www.bibliography.com/apa/how-to-alphabetize-your-apa-reference-list/). I think the original issue was simply noting that one name was out of order. Either way, it's really not a big deal how we order the names. We could say random order or alphabetical (by surname) if people feel strongly about this.

Regarding the discrepancy between CONTRIBUTING and MAINTAINERS, that is exactly why I wanted to merge them. They got out of sync at some point so it'll be easier to update if it only lives in one place.