search

TrustedFirmware-A / trusted-firmware-a

Read-only mirror for Trusted Firmware A
https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/
Other
5 stars 1 forks source link

rk3328: suspend to ram causes immediate panic on ddr4 #11

Open pgwipeout opened 4 months ago

pgwipeout commented 4 months ago

When suspending to ram on the rk3328 running ddr4 ram (roc-cc-rk3328) the board immediate reboots with no error produced. This issue does not occur on the rk3328 running ddr3 (rock64).

root@firefly:~# sync
root@firefly:~# systemctl suspend
root@firefly:~#
U-Boot TPL 2024.07-00614-g0f073e022ddc (Jul 04 2024 - 12:25:59)
DDR4, 333MHz
BW=32 Col=10 Bk=4 BG=2 CS0 Row=16 CS1 Row=16 CS=2 Die BW=16 Size=4096MB
Trying to boot from BOOTROM
Returning to boot ROM...

U-Boot SPL 2024.07-00614-g0f073e022ddc (Jul 04 2024 - 12:25:59 +0000)
Trying to boot from MMC1
## Checking hash(es) for config config-1 ... OK
## Checking hash(es) for Image atf-1 ... sha256+ OK
## Checking hash(es) for Image u-boot ... sha256+ OK
## Checking hash(es) for Image fdt-1 ... sha256+ OK
## Checking hash(es) for Image atf-2 ... sha256+ OK
NOTICE:  BL31: v2.11.0(release):v2.10.0-1218-g0dc0fda71
NOTICE:  BL31: Built : 12:11:30, Jul  4 2024
NOTICE:  BL31:Rockchip release version: v1.2

U-Boot 2024.07-00614-g0f073e022ddc (Jul 04 2024 - 12:25:59 +0000)

Model: Firefly roc-rk3328-cc
DRAM:  4 GiB
PMIC:  RK805 (on=0x40, off=0x00)
Core:  241 devices, 29 uclasses, devicetree: separate
MMC:   mmc@ff500000: 1, mmc@ff520000: 0
Loading Environment from MMC... Reading from MMC(0)... *** Warning - bad CRC, using default environment
odeprez commented 3 months ago

Cc @jwerner-chromium Pinged other RK platform maintainers by email.

jwerner-chromium commented 3 months ago

Sorry, I'm really just on this maintainer list for rk3399 and don't know anything about the other SoCs. I should maybe remove myself now that most development happens elsewhere.

odeprez commented 2 days ago

Hi @pgwipeout just curious if this is still an issue at your end? As there was no clear answer from community is there any chance you could investigate and push a change for resolving?

pgwipeout commented 2 days ago

Unfortunately it is still very much an issue, and only one that can be resolved by either Rockchip or a third party with access to their internal restricted documentation.

I suspect it's the same problem that rk3399 experienced with the ddr4 controller, but the memory layout is different between rk3328 and rk3399 so any possible fix cannot be ported directly over.

Is Rockchip aware of this method of reporting bugs yet?

odeprez commented 2 days ago

Hi I asked maintainers https://trustedfirmware-a.readthedocs.io/en/latest/about/maintainers.html#rockchip-platform-port on July 9th 2024 and pinged again on Aug 26th but got no answer. I can ping again but I'm unlikely to do better than this!

pgwipeout commented 5 hours ago

Please add xsf@rock-chips.com, derrick.huang@rock-chips.com, kever.yang@rock-chips.com, and jimmy.brisson@arm.com. The three rock-chip's emails are current contributors to TF-A and Jimmy Brisson authored the rk3399 fix. Also, please add me, pgwipeout@gmail.com.