search

TruthNZ / DominionShuffle

Fork of Dominion Shuffle
7 stars 7 forks source link

Re-enable card language selection #1

Closed UncleOwen closed 4 years ago

UncleOwen commented 8 years ago

Hi,

this pull-request re-enables card language selection.

Known issues:

TruthNZ commented 8 years ago

Does the new version released handle what you want?

UncleOwen commented 8 years ago

Hi,

I don't see a new version in google play store.

TruthNZ commented 8 years ago

There's two different Dominion Shuffles.

The earlier version of this one was at: https://play.google.com/store/apps/details?id=nl.spellenclubeindhoven.dominionshuffle But for some reason doesn't seem to show up in the Play store (at least not for me). However when I try to upload my updated version of it, they say that it still exists, and since has a different key (I don't have Jess's key to sign the app with), I can't update the version there. I'm trying to work with Google to sort something on this still.

The other Dominion Shuffle is: https://play.google.com/store/apps/details?id=com.LukasMike.dominionshuffle And is a completely different app.

The current latest release of our Dominion Shuffle is available at: https://github.com/TruthNZ/DominionShuffle/releases (latest version is the one with the green "Latest Release" tag next to it - annoyingly not always at the top. Until I can get it back up on the Play store you have to install this manually.

In terms of languages, it picks up the native language from your phone/tablet. If you want to display the card language at the moment you have to change your phone/tablet language and restart the app.

Gynn Rickerby Cell: 021 262 5205 There is no religion higher than the Truth.

On 7 January 2016 at 04:23, UncleOwen notifications@github.com wrote:

Hi,

I don't see a new version in google play store.

— Reply to this email directly or view it on GitHub https://github.com/TruthNZ/DominionShuffle/pull/1#issuecomment-169355233 .

UncleOwen commented 8 years ago

In terms of languages, it picks up the native language from your phone/tablet.

That would mean I have to change my phone language everytime I use DominionShuffle - not good :(

UncleOwen commented 8 years ago

The "Umlauts" (special German language characters) are broken. I would have taken a look at it, but both the git repository and the source tarball marked 1.12.0 only contain the 1.10.0 source code :(

TruthNZ commented 8 years ago

Bah ...

Thanks, I'll get onto it.

Gynn Rickerby Cell: 021 262 5205 There is no religion higher than the Truth.

On 7 January 2016 at 12:34, UncleOwen notifications@github.com wrote:

The "Umlauts" (special German language characters) are broken. I would have taken a look at it, but both the git repository and the source tarball marked 1.12.0 only contain the 1.10.0 source code :(

— Reply to this email directly or view it on GitHub https://github.com/TruthNZ/DominionShuffle/pull/1#issuecomment-169497241 .

UncleOwen commented 8 years ago

Btw, I really like the idea of defaulting the card language to the phone language... just add an override to the settings menu, please.

TruthNZ commented 8 years ago

Right, try this version: https://github.com/TruthNZ/DominionShuffle/releases/tag/v1.12.1

I know the sorting isn't working in non-English languages correctly, that's my next aim.

And looks like you can override the phone language for an App, without having to have your own separate language system like Jess did - but it's a little tricky. I'll see what I can do.

Gynn Rickerby Cell: 021 262 5205 There is no religion higher than the Truth.

On 7 January 2016 at 13:05, UncleOwen notifications@github.com wrote:

Btw, I really like the idea of defaulting the card language to the phone language... just add an override to the settings menu, please.

— Reply to this email directly or view it on GitHub https://github.com/TruthNZ/DominionShuffle/pull/1#issuecomment-169504381 .

UncleOwen commented 8 years ago

Strange characters gone, umlauts working.