search

Try / OpenGothic

Reimplementation of Gothic 2 Notr
MIT License
1.17k stars 85 forks source link

Feature Mods do not work #552

Closed rokuroo32 closed 11 months ago

rokuroo32 commented 11 months ago

Hello, OpenGothic runs on my system. The only problem I got is that I tried to install Feature Mods. Therefore I added .vdf files to my Gothic2/data folder. But it didn't seem to work. What do I have to do to get them run?

I have the Systempacket 1.7, Ninja 2.7.12 and the Playerkit installed.

Try commented 11 months ago

Hi, @rokuroo32 !

What exact mod you referencing? Can you provide a download link? Is there anything in .log file?

I have the Systempacket 1.7, Ninja 2.7.12 and the Playerkit installed.

This do not affect anything

rokuroo32 commented 11 months ago

I tried to install Quickloot https://www.worldofgothic.de/dl/download_679.htm. My log says OpenGothic v1.0 dev GPU = NVIDIA GeForce GTX 1650 Depth format = Depth32F Shadow format = Depth16 [phoenix] world: parsing object [MeshAndBsp % 0 0] [phoenix] bsp_tree: parsing chunk c000 [phoenix] bsp_tree: parsing chunk c010 [phoenix] bsp_tree: parsing chunk c040 [phoenix] bsp_tree: parsing chunk c045 [phoenix] bsp_tree: parsing chunk c050 [phoenix] bsp_tree: parsing chunk c0ff [phoenix] mesh: 1 bytes remaining in section b020 [phoenix] world: parsing object [VobTree % 0 0] [phoenix] world: parsing object [WayNet % 0 0] [phoenix] world: parsing object [EndMarker % 0 0] invalid particle system: "INVISIBLE_VOBBOX.3DS" unable to load sound fx: ENV_NIGHT_TONSOFINSECTS unable to load sound fx: OW_BIRD11 [phoenix] model_script: unexpected value for event_tag_type: " " [phoenix] model_script: 4 bytes remaining in section f5a3

The additional .vdf file is just not load correctly

Try commented 11 months ago

I've checked the mod - it was loaded correctly, just doesn't really have anything in it - only a few textures and binaries. Presumable this is not a mod, but DMA-hook. This is not something what can work

rokuroo32 commented 11 months ago

Ive tried it. It is loaded correctly when I wanna play it under steam. But not when I try to play it under OpenGothic. I also tried the RenderBarValue Mod. It does not show my health and mana https://www.worldofgothic.de/dl/download_671.htm. Did you unpack the mod under Gothic2/Data or Gothic2/Data/MODVDF? How did you install the mod? What do you mean with " Presumable this is not a mod, but DMA-hook. This is not something what can work "?

Try commented 11 months ago

Did you unpack the mod under Gothic2/Data or Gothic2/Data/MODVDF? How did you install the mod?

Drop VDF into Data folder

What do you mean with " Presumable this is not a mod, but DMA-hook. This is not something what can work "?

DMA stands for "direct memory access". When calling something 'mod', we usually mean new textures/models as well as scripts. DMA is different as it relies on host application volubilities/bugs to load some external executable code. Very similar to how virus may exploit application bugs, but this time not to do hard, but to build a new feature.

There are several issues with DMA:

You may found more info on how problematic DMA can be, when used as part of mod here: https://github.com/Try/OpenGothic/issues/231

rokuroo32 commented 11 months ago

Im confused. First you said that DMA does not work. Now you say it worked when you dropped it in your vdf folder. Is there a solution to my problem or not?

Try commented 11 months ago

Now you say it worked when you dropped it in your vdf folder.

This is not what I meant. Maybe it wasn't clear enough, from message above: load VDF is fine, just drop it to 'Data'. Will content of that VDF work after it loaded - depends.

Is there a solution to my problem or not?

If you want to use 'normal' mods created by modkit - that just works. If you want to inject external (ala *dll) code - that will not. Ninja/QuickLoot are injecting code - this will not work.

thokkat commented 11 months ago

I looked into quickloot some time ago but didn't continue. It did somewhat work but wasn't pr ready and there's no possibility to assign a key in menu to it.