search

Try / OpenGothic

Reimplementation of Gothic 2 Notr
MIT License
1.07k stars 78 forks source link

It's Christmas in Khorinis #578

Closed hwnde closed 3 months ago

hwnde commented 3 months ago

Trees have weird colored pixels which kinda look like Christmas lights from distance.

Windows 11, commit 26b816e36d05832f90851d2924209f14e6d88050 GPU: amd 6800 xt, meshlets off Screenshot 2024-02-13 225819

Try commented 3 months ago

HI, @hwnde and thanks for report!

Can you please provide more information about nature of artifact:

Can you please test it with -bl 0 and check if issue is reproducible?

thokkat commented 3 months ago

Have other case: Screenshot_20240214_205630

is it persistent, or broken pixels are different every frame?

It looks like raining or snowing for ~15s with torch as source. Then it looked normal. After a teleport to harbor and F8 flying back it started anew.

only trees (aka alpha-tested materials) are affected, or other materials as well?

Trees are ok here. Found this behavior only at tavern torch, e.g. brothel torch is ok.

Edit : Also visible at starting location torches but less pronounced.

Can you please test it with -bl 0 and check if issue is reproducible?

Same as -bl 1.

Try commented 3 months ago

@thokkat you talking about particle-effect, yet this is not how screen-shoot on topic looks like.

Notice, that there is mostly single pixels artifacts, and color are somewhat random. Imao, it looks a lot like warp/quad divergence bug. Also divergence explains, why issue is not observable on NVidia/Apple/Intel - they have HW support for variable indexing and do not care about shader code.

hwnde commented 3 months ago

@Try -bl 0 doesn't solve the issue

The broken pixels are persistent as long as I don't move the camera. It seems like this is present on any vegetation, i.e. leaves on water.

Try commented 3 months ago

marking it as help-wanted: I'm not familiar with such type of graphical artifacts. Normally, when it application bug, pixels(and draw-order) is not persistent, yet it's unlikely that AMD didn't manage to implement texturing.

Try commented 3 months ago

I've put some changes to pre-pass stage in a4b98a7

@hwnde I can't confirm it locally, please test it on you side, if you have time. Thanks!

hwnde commented 3 months ago

@Try It worked! The issue disappeared!